Support clang on macos prefix #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: https://bugs.gentoo.org/758167 Signed-off-by: Alexey Sokolov <[email protected]>
|
@grobian can you take a look? |
grobian
reviewed
Sep 19, 2024
| @@ -1695,7 +1698,6 @@ do_emerge_pkgs() { | |||
| -fortran | |||
| -gdbm | |||
| -git | |||
| -libcxx | |||
There was a problem hiding this comment.
Is this is going to break non-clang bootstraps?
grobian
reviewed
Sep 19, 2024
| @@ -2221,11 +2286,37 @@ bootstrap_stage3() { | |||
| ln -s bash "${ROOT}"/bin/sh | |||
| fi | |||
|
|
|||
| # Start using apps from the final destination Prefix | |||
| export PREROOTPATH="${ROOT}/usr/bin:${ROOT}/bin" | |||
There was a problem hiding this comment.
this var used to be picked up by portage, are we sure the below replacement is picked up by portage?
grobian
reviewed
Sep 19, 2024
| export PREROOTPATH="${ROOT}/usr/bin:${ROOT}/bin" | ||
| # Start using apps from new target | ||
| cat > "${ROOT}"/tmp/etc/env.d/10stage3 <<-EOF | ||
| PATH="${ROOT}/usr/bin:${ROOT}/bin:${ROOT}" |
There was a problem hiding this comment.
what is the trailing ROOT supposed to be here? what lives there?
grobian
reviewed
Sep 19, 2024
|
|
||
| # Get a sane bash, overwriting tmp symlinks | ||
| pre_emerge_pkgs "" "app-shells/bash" || return 1 | ||
| ln -s "${ROOT}"/bin/bash "${ROOT}"/usr/bin/bash |
There was a problem hiding this comment.
this is weird
bin should be a symlink to usr/bin, and thus this should break or complain about both arguments being the same file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.gentoo.org/758167