Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reset option for radio field #7004

Open
wants to merge 1 commit into
base: develop-patch
Choose a base branch
from

Conversation

gitlabisbetterthangithub

Should fix getkirby/getkirby.com#2410

Description

This is my attempt at fixing getkirby/getkirby.com#2410. This might not be correct as I might have misunderstood how the field properties table is generated. Hopefully it's correct.

@afbora
Copy link
Member

afbora commented Feb 14, 2025

You're right. But AFAIK we also need to unset the reset prop from select field since select field inherit from radio props.

@afbora afbora changed the title Update radio.php Add missing reset option for radio field Feb 14, 2025
@distantnative
Copy link
Member

I am wondering about two things:

  • Should a radio button be resettable? The native HTML element isn't.
  • If it is resettable, should the default be true - I have doubts as this could be a larger breaking change for setups that have been build with them not been resettable.

@bastianallgeier
Copy link
Member

@distantnative I would agree with you here. We don't want them to be resettable in the first place in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants