-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step Functions - Updated State Machine to support logging, tracing & encryption config. #8200
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8200 +/- ##
==========================================
- Coverage 94.53% 94.53% -0.01%
==========================================
Files 1155 1155
Lines 99707 99815 +108
==========================================
+ Hits 94261 94363 +102
- Misses 5446 5452 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bblommers Not sure how to reach that bit of missed coverage. Wondering if you could take a quick look when you have a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The entire stepfunctions parser has been borrowed from Localstack. I think that they use the resource_providers
to automatically serialize the response. But none of the files in that folder are used in Moto, so adding code to it will drop the code coverage a bit.
I'll merge it as is - the entire parser
implementation needs a bit more attention anyway; there are also other code snippets that are no longer used, a ton of functionality that we don't have tests for, etc.
But I'll leave that for another day, there's no need to block this PR. Thank you @zkarpinski!
Added additional configuration support for the SFN State Machines with Create, Describe & Update endpoints.