Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step Functions - Updated State Machine to support logging, tracing & encryption config. #8200

Merged
merged 13 commits into from
Oct 8, 2024

Conversation

zkarpinski
Copy link
Contributor

@zkarpinski zkarpinski commented Oct 4, 2024

Added additional configuration support for the SFN State Machines with Create, Describe & Update endpoints.

  • encryptionConfiguration
  • loggingConfiguration
  • tracingConfiguration

@zkarpinski zkarpinski changed the title Step Funtions - Updated State Machine Create, Describe, Update to support logging, tracing & encryption config. Step Funtions - Updated State Machine to support logging, tracing & encryption config. Oct 4, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.53%. Comparing base (43410b9) to head (5e820ea).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...source_providers/aws_stepfunctions_statemachine.py 0.00% 5 Missing ⚠️
moto/stepfunctions/parser/backend/state_machine.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8200      +/-   ##
==========================================
- Coverage   94.53%   94.53%   -0.01%     
==========================================
  Files        1155     1155              
  Lines       99707    99815     +108     
==========================================
+ Hits        94261    94363     +102     
- Misses       5446     5452       +6     
Flag Coverage Δ
servertests 28.83% <0.00%> (-0.01%) ⬇️
unittests 94.50% <79.31%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zkarpinski zkarpinski changed the title Step Funtions - Updated State Machine to support logging, tracing & encryption config. Step Functions - Updated State Machine to support logging, tracing & encryption config. Oct 8, 2024
@zkarpinski
Copy link
Contributor Author

@bblommers Not sure how to reach that bit of missed coverage. Wondering if you could take a quick look when you have a chance.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The entire stepfunctions parser has been borrowed from Localstack. I think that they use the resource_providers to automatically serialize the response. But none of the files in that folder are used in Moto, so adding code to it will drop the code coverage a bit.

I'll merge it as is - the entire parser implementation needs a bit more attention anyway; there are also other code snippets that are no longer used, a ton of functionality that we don't have tests for, etc.

But I'll leave that for another day, there's no need to block this PR. Thank you @zkarpinski!

@bblommers bblommers added this to the 5.0.17 milestone Oct 8, 2024
@bblommers bblommers merged commit 5cbfacf into getmoto:master Oct 8, 2024
52 of 53 checks passed
@zkarpinski zkarpinski deleted the sfn-enhancement branch October 8, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants