Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Add new methods #8608

Merged
merged 9 commits into from
Feb 22, 2025
Merged

Conversation

archinksagar
Copy link
Contributor

Adding the following methods for Logs

  • create_delivery
  • delete_delivery
  • delete_delivery_destination
  • delete_delivery_destination_policy
  • delete_delivery_source
  • describe_deliveries
  • describe_delivery_destinations
  • describe_delivery_sources
  • get_delivery
  • get_delivery_destination
  • get_delivery_destination_policy
  • get_delivery_source
  • put_delivery_destination
  • put_delivery_destination_policy
  • put_delivery_source

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 98.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.72%. Comparing base (41dd981) to head (7947a03).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
moto/logs/models.py 97.54% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8608      +/-   ##
==========================================
+ Coverage   92.65%   92.72%   +0.07%     
==========================================
  Files        1231     1242      +11     
  Lines      106791   107854    +1063     
==========================================
+ Hits        98946   100009    +1063     
  Misses       7845     7845              
Flag Coverage Δ
servertests 28.17% <12.91%> (+0.10%) ⬆️
unittests 92.70% <98.33%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for the (continued) contributions @archinksagar!

@bblommers bblommers added this to the 5.0.29 milestone Feb 22, 2025
@bblommers bblommers merged commit e1ddea8 into getmoto:master Feb 22, 2025
55 of 56 checks passed
@bblommers bblommers modified the milestones: 5.0.29, 5.1.0 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants