-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix breadcrumb timestamp casting and its tests #3546
Conversation
These tests were failing for me locally as the timestamps were without `tzinfo` and all were assumed UTC whereas my local timezone is BST at the moment. This patch fixes them by forcing things to have the UTC timezone.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #3546 +/- ##
=======================================
Coverage 84.49% 84.49%
=======================================
Files 133 133
Lines 13844 13855 +11
Branches 2927 2930 +3
=======================================
+ Hits 11697 11707 +10
- Misses 1422 1423 +1
Partials 725 725
|
@antonpirker ah, sorry 😅 was working on another patch and these failed. Didn't think of looking for an existing PR. |
Co-authored-by: Ivana Kellyer <[email protected]>
One of the |
These tests were failing for me locally as the timestamps were without
tzinfo
and all were assumed UTC whereas my local timezone is BST at the moment.This patch fixes the tests along with faulty/incomplete breadcrumb timestamp parsing logic on py3.7 and py3.8.