feat: CI runs for runtime and buildtime init on mobile
#1944
+92
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This reverts commit 75e96cd.
bitsandfoxes
commented
Jan 17, 2025
Comment on lines
+427
to
+428
| $results.crashTestPassed = RunTest -Name "crash" -SuccessString "CRASH TEST: Issuing a native crash" -FailureString "CRASH TEST: FAIL" | ||
| $results.hasCrashTestPassed = RunTest -Name "has-crashed" -SuccessString "HAS-CRASHED TEST: PASS" -FailureString "HAS-CRASHED TEST: FAIL" |
There was a problem hiding this comment.
There is no point in individually retrying those tests. The CrashTestWithServer has its own retry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an additional set of artifacts for mobile platforms by overwriting the
NativeInitializationTypesin theOptionsConfigurationscript fromRuntimetoBuildTime.These artifacts get annotated with their
init-typeand handed off to be run.While running this I noticed the timeout during initialization intermittently being hit, causing the tests to be flaky.
I'll follow up on this by moving the timeout to the
SentryOptionsto make them configurable.#skip-changelog