Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: iOS native bridge option creation #1963

Closed
wants to merge 2 commits into from

Conversation

bitsandfoxes
Copy link
Contributor

Fixes an issue reported in #1951 (comment)

<REDACTED>/data/jenkins/workspace/<REDACTED>/iOS/Build/iOS/Libraries/io.sentry.unity/SentryNativeBridge.m:37:9: error: performSelector names a selector which retains the object
   37 |         performSelector:@selector(initWithDict:didFailWithError:)
      |         ^
In module 'Sentry' imported from <REDACTED>/data/jenkins/workspace/<REDACTED>/iOS/Build/iOS/Libraries/io.sentry.unity/SentryNativeBridge.m:1:
<REDACTED>/Library/Developer/Xcode/DerivedData/Unity-iPhone-cseycvbiwfelbyekvlwxliadxfvi/Build/Intermediates.noindex/ArchiveIntermediates/Unity-iPhone/BuildProductsPath/Release-iphoneos/Sentry.framework/PrivateHeaders/SentryOptions+HybridSDKs.h:11:1: note: method 'initWithDict:didFailWithError:' declared here
   11 | - (_Nullable instancetype)initWithDict:(NSDictionary<NSString *, id> *)options
      | ^
1 error generated.

If I read that correctly, then this is due to the performSelector not respecting ARC rules properly.
Instead, we're creating the options now directly.

Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitsandfoxes
Copy link
Contributor Author

Superseded by #1964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants