Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devservices): Initial devservices configs #6323

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

hubertdeng123
Copy link
Member

This adds the initial devservices configs to snuba. This allows devservices to manage dependencies of snuba (clickhouse, redis, kafka) in order to aid in a smoother development environment.

Copy link

codecov bot commented Sep 18, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
686 1 685 2
View the top 1 failed tests by shortest run time
tests.clickhouse.optimize.test_optimize_tracker test_run_optimize_with_partition_tracker
Stack Traces | 0.447s run time
Traceback (most recent call last):
  File ".../clickhouse/optimize/test_optimize_tracker.py", line 178, in test_run_optimize_with_partition_tracker
    num_optimized = run_optimize_cron_job(
                    ^^^^^^^^^^^^^^^^^^^^^^
  File ".../clickhouse/optimize/optimize.py", line 142, in run_optimize_cron_job
    optimize_partition_runner(
  File ".../clickhouse/optimize/optimize.py", line 306, in optimize_partition_runner
    schedule = scheduler.get_next_schedule(partitions_to_optimize)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File ".../clickhouse/optimize/optimize_scheduler.py", line 100, in get_next_schedule
    raise OptimizedSchedulerTimeout(
snuba.clickhouse.optimize.optimize_scheduler.OptimizedSchedulerTimeout: Optimize job cutoff time exceeded 2024-09-18 23:00:00. Abandoning

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@hubertdeng123 hubertdeng123 marked this pull request as ready for review September 20, 2024 22:41
@hubertdeng123 hubertdeng123 requested a review from a team as a code owner September 20, 2024 22:41
@hubertdeng123 hubertdeng123 merged commit 573cc0e into master Sep 23, 2024
30 checks passed
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/add-devservices-configs branch September 23, 2024 22:47
hubertdeng123 added a commit that referenced this pull request Oct 2, 2024
This adds the devservices cli tool to be used once the venv is
activated. The devservices
[configurations](#6323) are
already added to the snuba repo so you should be able to use it as soon
as you install the new cli tool.

We are also offering a binary to be used for a system installation of
devservices (installation instructions in the README
[here](https://github.com/getsentry/devservices)). However, use this at
your own risk given that we're changing things pretty constantly and
bumping/downgrading versions isn't quite as easy as pinning to a version
in the venv.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants