Mastodon support #307
Merged
Mastodon support #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 232ab37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 10 +3
Lines 190 230 +40
Branches 0 7 +7
=========================================
+ Hits 190 230 +40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 7 out of 22 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- demo/package.json: Language not supported
- package.json: Language not supported
- packages/mastodon/package.json: Language not supported
- packages/everything/.eleventy.js: Evaluated as low risk
- demo/src/index.md: Evaluated as low risk
- packages/everything/lib/pluginDefaults.js: Evaluated as low risk
- demo/eleventy.config.js: Evaluated as low risk
- packages/everything/test/test-validatePlugins.js: Evaluated as low risk
- demo/src/mastodon.md: Evaluated as low risk
- .changeset/lemon-bugs-cross.md: Evaluated as low risk
- packages/mastodon/test/replace.test.mjs: Evaluated as low risk
- packages/mastodon/test/_validStrings.mjs: Evaluated as low risk
- packages/mastodon/test/_validUrls.mjs: Evaluated as low risk
- packages/mastodon/lib/defaults.js: Evaluated as low risk
- packages/mastodon/lib/pattern.js: Evaluated as low risk
Comments suppressed due to low confidence (3)
packages/mastodon/index.js:11
- The error message should be more descriptive. Suggested change: '[eleventy-plugin-embed-mastodon] You need to configure a Mastodon server URL. Please set the 'server' option in the plugin configuration to the hostname of your Mastodon instance.'
throw new Error("[eleventy-plugin-embed-mastodon] You need to configure a Mastodon server URL");
packages/mastodon/lib/replace.js:47
- [nitpick] The error message could be more descriptive by specifying which parameter is missing.
console.error("Missing Mastodon instance or status ID.");
packages/mastodon/lib/replace.js:74
- [nitpick] The error message could be more descriptive by specifying which parameter is missing.
console.error("Missing hostname or URL.");
| const federatedStatusQuery = `https://${hostname}/api/v1/statuses/${id}`; | ||
| try { | ||
| const {url} = await Fetch(federatedStatusQuery, { | ||
| duration: cacheDuration, |
There was a problem hiding this comment.
There is no validation to ensure that cacheDuration is in the correct format, which could lead to runtime errors.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Refactor tests
Add TODOs to pattern file Delete dead comment Start scaffolding out replace functions Basically works
Just some commentary Fix broken test
Try/Catch, plus some error testing Configure Vitest coverage Config, throw better errors Fix mocking, I think
Testing, console.error mocking, more reliable return values Tests, more resilient to failure cases More test coverage
Coverage: failing oembed case Remove redundant return values
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
This PR adds support for embedding Mastodon posts. Some things to know:
eleventy-plugin-embed-everything. Here's how to activate it. (If you installeleventy-plugin-embed-mastodonon its own, however, it will be active by default.)