Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serialize/Deserialize derives for mtl::EntryPointError #686

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

expenses
Copy link
Contributor

@expenses expenses commented Apr 9, 2021

This struct is used by the EntryPointMap in the gfx Metal backend. Implementing Serialize and Deserialize for this means that we can then serialize a SPIR-V -> MSL transformation cache (see also gfx-rs/gfx#3719 and gfx-rs/gfx#3716 (comment)).

Copy link
Member

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@kvark
Copy link
Member

kvark commented Apr 9, 2021

Please rebase

@expenses expenses force-pushed the metal-serialize-entry-point-error branch from 13cde69 to 81158bb Compare April 9, 2021 21:59
@kvark kvark merged commit 1fc8831 into gfx-rs:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants