-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some clippy errors #235
Conversation
…n the spirv grammar e.g. KHR extensions turning offical
I don't think we should hide these, but find a solution instead. It's not only the match arm but the duplicate enum variants may also be confusing/wrong. Rather have red CI long enough so that someone picks them up and fixes this, may actually be pretty trivial. |
In this case i will close this PR and open an issue for someone else to fix because i don't have the experience to fix the issue itself, if that's ok with you. |
@p3t3rix There are still two other issues that this PR fixes, you can leave it open for those and remove the |
…mmands in the spirv grammar e.g. KHR extensions turning offical" This reverts commit 44e540f.
Reverted the clippy allow and created an issue for the duplicated op-codes: #236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Wanted to fix some clippy errors to make CI/CD green again.
The clippy allow was added because extensions turning official still remain in the grammar.json and generate arms with the same opcode. Not sure if this should be fixed in another way but i think making CI green should be enough for the near future.
I just touched clippy errors that were thrown by ci/cd when it last ran (for example here https://github.com/gfx-rs/rspirv/runs/6061904152?check_suite_focus=true).