WIP: refactor(types)!: SampleCount newtype
#5915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
push-npqkorssmrwx
branch
5 times, most recently
from
4d67733
to
5e308bf
Compare
|
We shouldn't have this type in We can still have this type at the |
ErichDonGubler
force-pushed
the
push-npqkorssmrwx
branch
from
5e308bf
to
9c4be58
Compare
ErichDonGubler
force-pushed
the
push-npqkorssmrwx
branch
2 times, most recently
from
929129e
to
7d8934a
Compare
ErichDonGubler
force-pushed
the
push-npqkorssmrwx
branch
3 times, most recently
from
018c7c5
to
8c031f3
Compare
ErichDonGubler
force-pushed
the
push-npqkorssmrwx
branch
from
8c031f3
to
e9396df
Compare
|
Gonna abandon this for now, but will re-open once I can prioritize this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
N/A
Description
A mostly refactoring (but breaking) change I thought might be interesting. I'm not significantly invested in it. Each commit is atomic, and so the suggested review experience is commit-by-commit.
Testing
I believe I'm preserving
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.