Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] Ensure textureSampleLevel's level argument is an integer for depth textures #6529

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

[wgsl-in] Ensure textureSampleLevel's level argument is an integer for depth textures #6529

wants to merge 1 commit into from
+102 −15

Commits on Nov 14, 2024

  1. [wgsl-in] Ensure textureSampleLevel's level argument is an integer fo… 

    …r depth textures

Until now we accepted a float, as is the case for non-depth textures.
This makes us compliant with the spec.

The validator is updated to expect an Sint or Uint when the ImageClass
is ImageClass::Depth. The SPIR-V frontend converts the LOD argument
from float to Sint (assuming that it is representable), likewise The
SPIR-V backend now converts the LOD from either Sint or Uint to
Float. HLSL and MSL backends require no changes as they implicitly do
that conversion. GLSL does not support non-compare LOD samples,
therefore no changes are required.
    @jamienicol
    jamienicol committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4b56262 View commit details
    Browse the repository at this point in the history