-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llama : fix ctrl+c handler #11731
base: master
Are you sure you want to change the base?
llama : fix ctrl+c handler #11731
Conversation
For correct processing ctrl+c signal
Can you explain why this change is needed and which case does it fix? |
What you explained is not related to this change. I don't see why ctrl+c handler is related to that |
Wow, sorry about that! I made two changes. Regarding these changes: To allow the user to use Ctrl+C at any time, I think we need to register the event earlier in the process. |
That's why you should have a proper title and description for each PR. |
This introduce another bug, now I can no longer interrupt model loading. |
ref #11605 |
I'll double check everything today. Could you please clarify what operating system you use? |
I'm using MacOS. It should be the same on all platforms. I think you moved the handler to before model loading. |
ref #11605, ggml-org/llama.vim#35
For correct processing ctrl+c signal
Make sure to read the contributing guidelines before submitting a PR