Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From linkml to schemapack #156

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

From linkml to schemapack #156

wants to merge 10 commits into from

Conversation

sbilge
Copy link
Member

@sbilge sbilge commented Jun 28, 2024

This PR includes scripts and files to convert ghga-metadata-model from its LinkML representation to SchemaPack definition.
The bash script migrate_to_schemapack.sh calls the scripts in the required order and cleans up the repository from LinkML-related files and folders.

@sbilge sbilge requested a review from lkuchenb June 28, 2024 12:32
@sbilge sbilge requested review from dontseyit and removed request for lkuchenb July 10, 2024 11:26
dontseyit
dontseyit previously approved these changes Jul 22, 2024
Copy link
Member

@dontseyit dontseyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looks good to me, I'm not able to review schemapack logic at the moment but I suggest some improvements to the code.

scripts/build_resolved_schemapack.py Outdated Show resolved Hide resolved
scripts/build_resolved_schemapack.py Outdated Show resolved Hide resolved
scripts/build_resolved_schemapack.py Outdated Show resolved Hide resolved
scripts/extract_class_content.py Show resolved Hide resolved
scripts/extract_relationships.py Outdated Show resolved Hide resolved
@sbilge
Copy link
Member Author

sbilge commented Sep 6, 2024

I updated the branch based on the ghga-metadata-schema (on linkml) changes. I introduced a new condition to extract_relationships.py script to prevent the script from interpreting two specific fields as a relationship. The explanation is also provided in the function definition of slots_with_class_range. The scripts extract_class_content.py, extract_relationships.py, and linkml_to_schemapack.py will not live on the repository and they are only included in this PR for archiving purposes. After getting approval on the migration strategy, I will once more clean up the repository.

@sbilge sbilge requested a review from dontseyit September 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants