Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: improve entity fetching flow #132

Merged
merged 3 commits into from
Jan 17, 2025
Merged

perf: improve entity fetching flow #132

merged 3 commits into from
Jan 17, 2025

Conversation

trag1c
Copy link
Member

@trag1c trag1c commented Jan 16, 2025

Built on top of #129. The wait time decreases significantly when multiple entities are mentioned for the first time in a message:
image

@trag1c trag1c added internal Tooling and non-user-facing improvements improvement labels Jan 16, 2025
@trag1c trag1c force-pushed the async-entity-fetching branch from 5ae8578 to 8855fe0 Compare January 17, 2025 20:27
Uzaaft
Uzaaft approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Blazingly fast

@Uzaaft Uzaaft mentioned this pull request Jan 17, 2025
Merged
@trag1c trag1c force-pushed the async-entity-fetching branch from 8855fe0 to 26d0c6a Compare January 17, 2025 20:42
@trag1c trag1c changed the base branch from githubkit to main January 17, 2025 20:44
@trag1c trag1c force-pushed the async-entity-fetching branch from 26d0c6a to 188d1d2 Compare January 17, 2025 20:45
@trag1c trag1c merged commit 54cbd56 into main Jan 17, 2025
1 check passed
@trag1c trag1c deleted the async-entity-fetching branch January 17, 2025 20:49
@sentry-io Sentry.io
Copy link

sentry-io bot commented Jan 21, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ GraphQLFailed: data={'repository': {'discussion': None}} errors=[GraphQLError(type='NOT_FOUND', message='Could n... app.components.entity_mentions.discussions in g... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzaaft Uzaaft Uzaaft approved these changes

Assignees
No one assigned
Labels
internal Tooling and non-user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trag1c @Uzaaft