Sanitize markdown in GitHub entity titles #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-kat
commented
Feb 24, 2025
| @@ -43,7 +44,8 @@ async def load_emojis() -> None: | |||
|
|
|||
|
|
|||
| def _format_mention(entity: Entity, kind: EntityKind) -> str: | |||
| headline = ENTITY_TEMPLATE.format(kind=kind, entity=entity) | |||
| title = escape_special(entity.title) | |||
There was a problem hiding this comment.
Not sure if I should inline this; I liked the formatting with the new title variable more, and it's more consistent with the rest of them, so I kept it this way. Let me know if you want it changed.
00-kat
commented
Feb 25, 2025
| @@ -101,3 +106,24 @@ async def remove_view_after_timeout( | |||
| await asyncio.sleep(timeout) | |||
| with suppress(discord.NotFound, discord.HTTPException): | |||
| await message.edit(view=None) | |||
|
|
|||
|
|
|||
| def escape_special(s: str) -> str: | |||
There was a problem hiding this comment.
Note: for some performance characteristics, there are five regexes run in this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.
Continuation of #156, thank you GitHub.