Move stickers #167
Open
Move stickers #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the “fake-nitro” extension in some things-that-shall-not-be-named.
This does not currently handle:
- Stickers stored as GIFs, which seem to be on a different CDN despite
what the API says.
This will never handle:
- Stickers stored as Lottie images.
- Proper display of animated PNGs, since Discord does not seem to
like them.
For whatever reason, Discord stores stickers stored as GIFs on a different CDN, but points to the one used for PNGs, APNGs and Lottie images when querying the API for a sticker's URL. This change attempts to work around that by trying both CDNs and ensuring that any sticker URL used is actually accessible.
These embeds could represent other moved stickers, or embeds created by applications for other purposes. Discord renders message containing both a sticker and an embed by showing the sticker beneath the embed; our stickers are thus appended to the end rather than the beginning.
I had previously missed the `format` attribute in stickers; using this it is now possible to include an error message instead of silently failing.
I had previously completely forgotten about the existence of HEAD, and so went with streaming the contents but never reading it.
00-kat
force-pushed
the
move-stickers
branch
from
4127c60 to
ffbfbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #158, thank you GitHub.
Closes the second part of #155, and based on #166 (merge that first).
Nothing much can be done about Lottie stickers (which some of the built-in ones are stored as) and animated stickers stored as APNGs (which show up as the first frame) however.