Fix /add relnote for PCRE2 issues

I tried running `/add relnote` for the most recent PCRE2 issue in git-for-windows/git#5398 (comment) but it failed: The following deployment(s) are missing: * https://wingit.blob.core.windows.net/i686/pcre2-pcre2-10.45-1-i686.pkg.tar.xz * https://wingit.blob.core.windows.net/x86-64/pcre2-pcre2-10.45-1-x86_64.pkg.tar.xz * https://wingit.blob.core.windows.net/i686/mingw-w64-i686-pcre2-pcre2-10.45-1-any.pkg.tar.xz * https://wingit.blob.core.windows.net/x86-64/mingw-w64-x86_64-pcre2-pcre2-10.45-1-any.pkg.tar.xz Clearly, GitForWindowsHelper was parsing the version incorrectly. Let's fix that. Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows · Feb 21, 2025 · 8061e70 · 8061e70
1 parent 1300a1b
commit 8061e70
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/GitForWindowsHelper/component-updates.js b/GitForWindowsHelper/component-updates.js
@@ -14,7 +14,7 @@ const guessComponentUpdateDetails = (title, body) => {
     else if (['clang', 'llvm', 'mingw-w64-clang'].includes(package_name)) package_name = 'mingw-w64-llvm'
 
     version = version
-        .replace(/^(GCM |openssl-|OpenSSL_|v|V_|GnuTLS |tig-|Heimdal |cygwin-|PCRE2-|Bash-|curl-|gnupg-|is-)/, '')
+        .replace(/^(GCM |openssl-|OpenSSL_|v|V_|GnuTLS |tig-|Heimdal |cygwin-|PCRE2-|Bash-|curl-|gnupg-|is-|pcre2-)/, '')
         .replace(/\s+patch\s+/, '.')
         .replace(/_/g, '.')
         .replace(/-release$/, '')

diff --git a/__tests__/component-updates.test.js b/__tests__/component-updates.test.js
@@ -211,6 +211,16 @@ http://www.gnutls.org/news.html#2023-02-10`
         package: 'msys2-runtime',
         version: '3.4.7'
     })
+    expect(await guessReleaseNotes(context, {
+        labels: [{ name: 'component-update' }],
+        title: '[New pcre2 version] pcre2-10.45',
+        body: `\n\nhttps://github.com/PCRE2Project/pcre2/releases/tag/pcre2-10.45`
+    })).toEqual({
+        type: 'feature',
+        message: 'Comes with [PCRE2 v10.45](https://github.com/PCRE2Project/pcre2/releases/tag/pcre2-10.45).',
+        package: 'pcre2',
+        version: '10.45'
+    })
 })
 
 test('getMissingDeployments()', async () => {