Introduce short-and-sweet functions to send an HTTP response

By calling `return ok(...)` or `return withStatus(...)`, it is now really easy and concise to exit from the Azure Function by sending an HTTP response. Signed-off-by: Johannes Schindelin <[email protected]>
git-for-windows · Dec 1, 2022 · d319ff1 · d319ff1
1 parent 5f575e4
commit d319ff1
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/LeaveMeAloneGitHubApp/index.js b/LeaveMeAloneGitHubApp/index.js
@@ -4,15 +4,23 @@ const validateGitHubWebHook = require('./validate-github-webhook')
 const gitHubApiRequestAsApp = require('./github-api-request-as-app')
 
 module.exports = async function (context, req) {
+    const withStatus = (status, headers, body) => {
+        context.res = {
+            status,
+            headers,
+            body
+        }
+    }
+
+    const ok = (body) => {
+        withStatus(undefined, undefined, body)
+    }
+
     try {
         validateGitHubWebHook(context)
     } catch (e) {
         context.log(e)
-        context.res = {
-            status: 403,
-            body: `Go away, you are not a valid GitHub webhook: ${e}`,
-        }
-        return
+        return withStatus(403, undefined, `Go away, you are not a valid GitHub webhook: ${e}`)
     }
 
     if (req.headers['x-github-event'] === 'installation' && req.body.action === 'created') {
@@ -26,10 +34,7 @@ module.exports = async function (context, req) {
             }
         } catch (e) {
             context.log(e)
-            context.res = {
-                status: 500,
-                body: `Error:\n${e}`,
-            }
+            return withStatus(500, undefined, `Error:\n${e}`)
         }
         return
     }
@@ -39,8 +44,5 @@ module.exports = async function (context, req) {
     context.log("Got body")
     context.log(req.body)
 
-    context.res = {
-        // status: 200, /* Defaults to 200 */
-        body: `Received event ${req.headers["x-github-event"]}`
-    }
+    ok(`Received event ${req.headers["x-github-event"]}`)
 }