Fix PCRE2 /add release note
#125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Schindelin <[email protected]>
I tried running `/add relnote` for the most recent PCRE2 issue in git-for-windows/git#5398 (comment) but it failed: The following deployment(s) are missing: * https://wingit.blob.core.windows.net/i686/pcre2-pcre2-10.45-1-i686.pkg.tar.xz * https://wingit.blob.core.windows.net/x86-64/pcre2-pcre2-10.45-1-x86_64.pkg.tar.xz * https://wingit.blob.core.windows.net/i686/mingw-w64-i686-pcre2-pcre2-10.45-1-any.pkg.tar.xz * https://wingit.blob.core.windows.net/x86-64/mingw-w64-x86_64-pcre2-pcre2-10.45-1-any.pkg.tar.xz Clearly, GitForWindowsHelper was parsing the version incorrectly. Let's fix that. Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just tried running that slash command in git-for-windows/git#5398 and it failed. Let's fix that.
While at it, I noticed that the ARM64 packages aren't checked, so let's fix that, too.