When stack fully emptied, disreguard old PR information #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Caleb-T-Owens
force-pushed
the
empty-stack-new-stack
branch
from
e654da6 to
662abf0
Compare
krlvi
reviewed
Jan 17, 2025
| @@ -542,6 +542,11 @@ impl Stack { | |||
| } | |||
|
|
|||
| if self.heads.iter().all(|branch| branch.archived) { | |||
| // Remove previous PR information so it looks like we started a new stack | |||
| for head in self.heads.iter_mut() { | |||
There was a problem hiding this comment.
Do you want to do this for all or only for the integrated ones?
There was a problem hiding this comment.
I think so. Getting rid of context too eagerly could be anoying
Caleb-T-Owens
force-pushed
the
empty-stack-new-stack
branch
from
662abf0 to
8d7f481
Compare
Caleb-T-Owens
force-pushed
the
empty-stack-new-stack
branch
from
8d7f481 to
3fd6fda
Compare
Caleb-T-Owens
force-pushed
the
empty-stack-new-stack
branch
from
3fd6fda to
9ddd80d
Compare
krlvi
approved these changes
Jan 20, 2025
Caleb-T-Owens
force-pushed
the
empty-stack-new-stack
branch
from
9ddd80d to
0419378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.