feat: themeable HighlightingManager #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The default environment is set as static, so it can be updated by GitExtensions with theme colors. Any overrides in the actual themes would still be overriding the default environment colors (the theme overrides were recently removed though). * Make it possible to set colors as adaptable, to control if they should be adapted for the themes or not. Highlight colors hardcoded in the interface or in .xshd files (unless they are system colors) should generally be adapted, but colors in themes are likely to be set to the intended color.
mstv
reviewed
Jan 26, 2025
Project/Src/Document/HighlightingStrategy/DefaultHighlightingStrategy.cs
Outdated
Show resolved
Hide resolved
Project/Src/Document/HighlightingStrategy/DefaultHighlightingStrategy.cs
Outdated
Show resolved
Hide resolved
Project/Src/Document/HighlightingStrategy/HighlightingManager.cs
Outdated
Show resolved
Hide resolved
* The default environment is set as static, so it can be updated by GitExtensions with theme colors. Any overrides in the actual themes would still be overriding the default environment colors (the theme overrides were recently removed though). * Make it possible to set colors as adaptable, to control if they should be adapted for the themes or not. Highlight colors hardcoded in the interface or in .xshd files (unless they are system colors) should generally be adapted, but colors in themes are likely to be set to the intended color.
mstv
previously approved these changes
Jan 26, 2025
mstv
dismissed
their stale review
Another newline at eof was removed. Check editor settings [file]?
* The default environment is set as static, so it can be updated by GitExtensions with theme colors. Any overrides in the actual themes would still be overriding the default environment colors (the theme overrides were recently removed though). * Make it possible to set colors as adaptable, to control if they should be adapted for the themes or not. Highlight colors hardcoded in the interface or in .xshd files (unless they are system colors) should generally be adapted, but colors in themes are likely to be set to the intended color.
This project uses \n and MS VS constantly trashes the newlines. |
mstv
approved these changes
Jan 26, 2025
RussKie
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default environment is set as static, so it can be updated by GitExtensions with theme colors.
Any overrides in the actual themes would still be overriding the default environment colors (the theme overrides were recently removed though).
Make it possible to set colors as adaptable, to control if they should be adapted for the themes or not.
Highlight colors hardcoded in the interface or in .xshd files (unless they are system colors)
should generally be adapted, but colors in themes are likely to be set to the intended color.