Java, C#: Ensure variable is used in all disjuncts

github · Jan 29, 2025 · 7055095 · 7055095
1 parent 13e0829
commit 7055095
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll b/csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll
@@ -372,7 +372,7 @@ module ModelGeneratorInput implements ModelGeneratorInputSig<Location, CsharpDat
     or
     i = 4 and ExternalFlow::partialModel(api, _, _, _, _, result) // parameters
     or
-    i = 5 and result = "" // ext
+    i = 5 and result = "" and exists(api) // ext
   }
 
   string partialNeutralModelRow(Callable api, int i) {

diff --git a/java/ql/src/utils/modelgenerator/internal/CaptureModels.qll b/java/ql/src/utils/modelgenerator/internal/CaptureModels.qll
@@ -293,7 +293,7 @@ module ModelGeneratorInput implements ModelGeneratorInputSig<Location, JavaDataF
     or
     i = 4 and result = ExternalFlow::paramsString(api) // parameters
     or
-    i = 5 and result = "" // ext
+    i = 5 and result = "" and exists(api) // ext
   }
 
   string partialNeutralModelRow(Callable api, int i) {