Match autoformatting, add QLDoc references

github · Feb 26, 2025 · ad84e9b · ad84e9b
1 parent 335bf6b
commit ad84e9b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/csharp/ql/src/Bad Practices/PathCombine.qhelp b/csharp/ql/src/Bad Practices/PathCombine.qhelp
@@ -11,6 +11,8 @@
 </recommendation>
 <references>
 
+  <li>Microsoft Learn, .NET API browser, <a href="https://learn.microsoft.com/en-us/dotnet/api/system.io.path.combine?view=net-9.0">Path.Combine</a>.</li>
+  <li>Microsoft Learn, .NET API browser, <a href="https://learn.microsoft.com/en-us/dotnet/api/system.io.path.join?view=net-9.0">Path.Join</a>.</li>
 
 </references>
 </qhelp>
diff --git a/csharp/ql/src/Bad Practices/PathCombine.ql b/csharp/ql/src/Bad Practices/PathCombine.ql
@@ -14,4 +14,4 @@ import semmle.code.csharp.frameworks.System
 
 from MethodCall call
 where call.getTarget().hasFullyQualifiedName("System.IO", "Path", "Combine")
-select call, "Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them."
+select call, "Call to System.IO.Path.Combine."
diff --git a/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected b/csharp/ql/test/query-tests/Bad Practices/Path Combine/PathCombine.expected
@@ -1 +1 @@
-| PathCombine.cs:7:9:7:54 | call to method Combine | Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them. |
+| PathCombine.cs:7:9:7:54 | call to method Combine | Call to System.IO.Path.Combine. |
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		\| PathCombine.cs:7:9:7:54 \| call to method Combine \| Path.Combine may silently discard its initial arguments if the latter are absolute paths. Use Path.Join to consistently join them. \|
		\| PathCombine.cs:7:9:7:54 \| call to method Combine \| Call to System.IO.Path.Combine. \|