Js/Py/Rb: Report any extracted file as successfully extracted #15256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
previously approved these changes
Jan 17, 2024
erik-krogh
previously approved these changes
Jan 17, 2024
tausbn
previously approved these changes
Jan 17, 2024
henrymercer
previously approved these changes
Jan 17, 2024
…ithub.com/sidshank/codeql into change/adjust-extracted-files-diagnostics
sidshank
dismissed stale reviews from henrymercer, tausbn, erik-krogh, and hvitved
via
2c683c9
|
@hvitved @henrymercer @tausbn @erik-krogh I needed to add change notes - this is now done. My apologies for the review dismissals. Could you please take one more look and add your reviews? 🙏🏼 |
henrymercer
approved these changes
Jan 17, 2024
tausbn
approved these changes
Jan 17, 2024
erik-krogh
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files scanned section of the tool status page is currently pessimistic about which files are scanned. If there is a single extractor warning in the file, the file is marked as not scanned.
The changes in this pull request modify the CodeQL diagnostic queries to report all files inspected by the extractor, such that partially extracted files are accounted for in the diagnostics data presented on the Tool Status Page.