-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: add .def
to exceptions to AV rule 32
#15265
Conversation
This is used as textual includes in several projects for macro metaprogramming, for example in `llvm-project` and in `swift` (and since some time in our internal codebase as well).
fea8bd9
to
27160b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once we have a successful DCA run!
Do you know which DCA query suite contains this query? |
silly me, I can just manually select this one query :) |
Isn't the query just in the nightly suite? |
It should be, yes. You can check by running |
still it's ok to manually select the query if the PR only affects that one query, right? |
Preferably you'll run the nightly suite, as that'll show whether there are any adverse consequences due to your change and the way queries interact (I expect this to be pretty boring here). |
DCA shows one repository with less alerts, which were indeed false positives (including .def files for macro metaprogramming). |
This is used as textual includes in several projects for macro metaprogramming, for example in
llvm-project
and inswift
(and since some time in our internal codebase as well).