Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Migrate AppenderOrSprinter model to models-as-data #15267

Merged

Conversation

atorralba
Copy link
Contributor

Migrates the existing dataflow model for fmt.[Append|Sprint][|f|ln] to models as data to increase its precision regarding access paths.

It also deprecates the old model and creates a new class AppenderOrSprinterFunc without the dataflow logic.

@atorralba atorralba requested a review from owen-mc January 9, 2024 15:36
@atorralba atorralba requested a review from a team as a code owner January 9, 2024 15:36
Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

go

Generated file changes for go

  • Changes to framework-coverage-go.rst:
-    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",8,566,
+    `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``",8,577,
-    Totals,,8,826,
+    Totals,,8,837,
  • Changes to framework-coverage-go.csv:
- fmt,,5,,5,
+ fmt,,16,,16,

co-authored-by: Owen Mansel-Chan <[email protected]>
@atorralba
Copy link
Contributor Author

All suggestions applied, thanks for the review @owen-mc.

@atorralba
Copy link
Contributor Author

And now the easily-offended tests are also fixed 😄.

@owen-mc
Copy link
Contributor

owen-mc commented Jan 10, 2024

Yes, there are two or three tests that include information about summaries of library functions. There's a PR in progress to fix some of them, so it may be better in future.

@atorralba atorralba merged commit ca0a1dc into github:main Jan 10, 2024
11 checks passed
@atorralba atorralba deleted the atorralba/go/fmt-appenderorsprinter-mad branch January 10, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants