Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: fix stats for databaseMetadata relation #18542

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

nickrolfe
Copy link
Contributor

#18529 passed all its CI checks, but caused an internal stats-checking unit test to fail. This should fix it.

@Copilot Copilot bot review requested due to automatic review settings January 20, 2025 17:04
@nickrolfe nickrolfe requested a review from a team as a code owner January 20, 2025 17:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • java/ql/lib/config/semmlecode.dbscheme.stats: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the Java label Jan 20, 2025
@smowton
Copy link
Contributor

smowton commented Jan 20, 2025

Looks plausible ref the existing stats for externalData 👍

@nickrolfe nickrolfe merged commit 3e57071 into main Jan 20, 2025
11 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/java-stats branch January 20, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants