Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: Treat more file patterns as tsconfig-like files #18622

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Jan 29, 2025

Improves our handling of the situation where the tsconfig.json file includes nothing, but references another file that does, but is not called tsconfig.json.

We could do this by following "references" and "extends" and extract more files based on that, but for now I've done the simple thing by just treating more files as tsconfig-like files.

@github-actions github-actions bot added the JS label Jan 29, 2025
@asgerf asgerf marked this pull request as ready for review January 30, 2025 19:35
@Copilot Copilot bot review requested due to automatic review settings January 30, 2025 19:35
@asgerf asgerf requested a review from a team as a code owner January 30, 2025 19:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

javascript/ql/test/library-tests/TypeScript/TSConfigReferences/src/main.ts:1

  • No test coverage is provided for the newly introduced 'main' function. Please add a test to ensure it is exercised and verifies expected behavior.
export function main(foo: string) {

javascript/extractor/src/com/semmle/js/extractor/AutoBuild.java:1111

  • No coverage is introduced for this new function. Please ensure that the logic is tested with multiple file names to confirm correct detection of TS config files.
public static boolean treatAsTSConfig(String basename) {

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@asgerf asgerf added the no-change-note-required This PR does not need a change note label Jan 30, 2025
@asgerf asgerf removed the no-change-note-required This PR does not need a change note label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants