Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifies lib exclude, adds example lib include #4563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mark-lazarides
Copy link

explicitly excludes the _Libraries directory, and provides example of adding sub directories back in. Should be used for including custom and third party (non -Beckhoff shipped) libraries, improving maintainability

Reasons for making this change:
The _Libraries directory was blanket ignored before. If using a project with non-Beckhoff libraries, it can become hard to maintain the project, as sourcing those libraries is challenging. The ignore file was modified to explicitly ignore the _Libraries directory (adding wildcarding to ensure it is expllicitly selected).

A commented out example is provided guiding users on how to include specific library directories.

explicitly excludes the `_Libraries` directory, and provides example of
adding sub directories back in. Should be used for including custom and
third party (non -Beckhoff shipped) libraries, improving maintainability
@mark-lazarides
Copy link
Author

@sagatowski - as original submitter of the TwinCAT3.gitignore, could you comment on this PR?

@sagatowski
Copy link
Contributor

@mark-lazarides Is the idea here that I can always have a separate library with me all the time and version control it? In other words, libraries that are default not installed through the TwinCAT installer, like in your example TcUnit? (so that I can install it on a clean and fresh system without having to download it separately)?

@mark-lazarides
Copy link
Author

Yes. As there is no default package manager for versions less than 4024, this also seems the quickest way to enable specific recreation of solutions/deployments, particularly when managing multiple sources of libs

@sagatowski
Copy link
Contributor

@mark-lazarides I like the idea! I sometimes include the additional libraries in a separate folder in the repo if the user doesn't want to download them separately. Many of these end up as Miscellaneous (the default folder for everything unless you are using library categories), and in that case you could even put the whole miscellaneous folder as an exception I guess (I at least think that there is a Misc folder created for all 3rd party libraries that are not using library categories).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants