Support select elements
#55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theinterned this work aims to complement #30. |
theinterned
reviewed
Feb 6, 2024
seanpdoyle
force-pushed
the
html-select-element-support
branch
from
71a2686 to
4d5340d
Compare
seanpdoyle
changed the title
select:not([multiple]) elementsselect elements
|
@theinterned I've incorporated your suggestion on looping over |
|
@seanpdoyle there are conflicts since merging #30 — I'll give this a review once those are resolved. Thank you 🙏 |
First, introduce the `PersistableElement` type to incorporate `<input>`, `<textarea>`, and `<select>` elements. Next, incorporate some special handling for `HTMLSelectElement`, since they don't have a `.defaultValue` property. Support for `HTMLSelectElement` instances is generalized for both single and `[multiple]` elements by looping over [HTMLSelectElement.selectedOptions][] while persisting, then setting [HTMLSelectElement.selected][] when restoring. [HTMLSelectElement.selectedOptions]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions [HTMLSelectElement.selected]: https://developer.mozilla.org/en-US/docs/Web/API/HTMLOptionElement#instance_properties
seanpdoyle
force-pushed
the
html-select-element-support
branch
from
4d5340d to
8154f26
Compare
|
@theinterned I've pushed up a rebased commit. Thank you! |
theinterned
approved these changes
Feb 8, 2024
| .filter(field => shouldResumeField(field, storageFilter)) | ||
| .map(field => { | ||
| if (field instanceof HTMLSelectElement) { | ||
| return [field.id, Array.from(field.selectedOptions).map(option => option.value)] |
There was a problem hiding this comment.
ah cool using selectedOptions is really nice! I didn't realize it worked equally for multiple and non-multiple selects.
|
🚀 This has shipped in v0.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, introduce the
PersistableElementtype to incorporate<input>,<textarea>, and<select>elements.Next, incorporate some special handling for
HTMLSelectElement, sincethey don't have a
.defaultValueproperty.Support for
HTMLSelectElementinstances is generalized for bothsingle and
[multiple]elements by looping overHTMLSelectElement.selectedOptions while persisting, then setting
HTMLSelectElement.selected when restoring.