Organization onboarding welcome message #20577
Draft
+7,480
−2,278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…essage fields This change modifies the organization onboarding settings to make welcome message fields optional, including: - Making message, featured member ID, and avatar URL optional - Removing the footer field - Adding validation to prevent enabling an empty welcome message Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
This commit introduces several improvements to the welcome message feature: - Split welcome message components into separate files for better organization - Replace @uiw/react-md-editor with react-markdown - Update TypeScript to version 5.7.3 - Modify organization member listing to exclude deleted and admin users - Add OrganizationJoinModal for new user onboarding flow - Simplify welcome message preview and editor components Tool: gitpod/catfood.gitpod.cloud
filiptronicek
commented
Feb 4, 2025
| window.opener.postMessage(message + "&newUser=" + newUser, `https://${window.location.hostname}`); | ||
|
|
||
| if (newUser === "true") { | ||
| localStorage.setItem("newUserOnboardingPending", newUser); |
There was a problem hiding this comment.
we use this localStorage item as a token, which the workspace list redeems in exchange for a modal with the organization join message.
This commit addresses two minor issues: - Add error handling for localStorage in complete-auth page - Remove redundant CSS classes for Markdown preview and use Markdown component props instead Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
- Extract UpdateTeamSettingsOptions type for consistent error handling - Move gitpodWelcomeSubheading to WelcomeMessageConfigurationField - Add error state and handling in WelcomeMessageEditor - Refactor update methods to support optional error throwing Tool: gitpod/catfood.gitpod.cloud
Unfortunately, this entails having a duplicate `OnboardingSettings` message specified in the proto definition Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
filiptronicek
commented
Feb 5, 2025
| @@ -151,6 +169,23 @@ message TimeoutSettings { | |||
| } | |||
|
|
|||
| message UpdateOrganizationSettingsRequest { | |||
| message OnboardingSettings { | |||
There was a problem hiding this comment.
unfortunately, I had to make a request / response split for the types here, so there's duplication.
This is because of the following fields:
featured_member_resolved_avatar_urlis only available in responsesupdate_recommended_repositoriesis only available in requests
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
… add iam session unit test assertions - Refactor import types to use the updated OrganizationSettings_OnboardingSettings_WelcomeMessage - Adjust type references in OrgMemberAvatarInput, WelcomeMessageConfigurationField, and WelcomeMessageEditor - Add newUser flag checks in IAM session app spec - Remove unused import in organization service Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a customizable welcome message for organization newjoiners.
Related Issue(s)
Fixes CLC-1065
How to test
Documentation
TBD
/hold