Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-mk2] update to support k8s 0.30 API #20580

Merged
merged 7 commits into from
Feb 7, 2025
Merged

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Feb 5, 2025

Description

Without which, we cannot remove the gitpod finalizer, pods do not terminate, and as such, we do not scale down nodes

ToDo:

  • upgrade to k8s 1.30 (packaes 0.30.9)
    • fix all failing go test ./... tests
    • adjust all API changes
  • actually use new API to apply AppAmor depending on ServerVersion
  • run ginkgo tests
  • fix all leeway build issues
  • test in preview
    • worked flawlessly, server version v1.27.16
  • test on catfood
    • worked flawlessly, Server Version: v1.30.9

Related Issue(s)

Fixes CLC-1131

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link

socket-security bot commented Feb 6, 2025

 - update the go-update-wc-deps.sh script to handle the brunt of that transition
 - fixes Maintenance- + Subscriber-Controller
 - document steps

Tool: gitpod/catfood.gitpod.cloud
…rsion to support k8s 1.30+

Tool: gitpod/catfood.gitpod.cloud
@geropl geropl force-pushed the kylos101/clc-1131 branch from 64cb1b2 to 9b31e79 Compare February 6, 2025 16:56
Copy link

socket-security bot commented Feb 6, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
@geropl
Copy link
Member

geropl commented Feb 6, 2025

@kylos101 I pushed my changes, and update the description above with what I did/did not get to. I have to drop for today, but could pick up again tomorrow morning.

Currently, I'm stuck on the ws-daemon tests, which are all failing because of listen tcp :8080: bind: address already in use. It sounds rather mundane - and I have no clue why it should pop now - but haven't looked yet. 🙂

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 😛 , tested and works ✔️

@geropl
Copy link
Member

geropl commented Feb 7, 2025

/unhold

@roboquat roboquat merged commit 58c9a18 into main Feb 7, 2025
75 of 76 checks passed
@roboquat roboquat deleted the kylos101/clc-1131 branch February 7, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants