-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-manager-mk2] update to support k8s 0.30 API #20580
Conversation
c82bc46
to
64cb1b2
Compare
Tool: gitpod/catfood.gitpod.cloud
- update the go-update-wc-deps.sh script to handle the brunt of that transition - fixes Maintenance- + Subscriber-Controller - document steps Tool: gitpod/catfood.gitpod.cloud
…rsion to support k8s 1.30+ Tool: gitpod/catfood.gitpod.cloud
64cb1b2
to
9b31e79
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Tool: gitpod/catfood.gitpod.cloud
…er/v3 Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
…rd.... Tool: gitpod/catfood.gitpod.cloud
@kylos101 I pushed my changes, and update the description above with what I did/did not get to. I have to drop for today, but could pick up again tomorrow morning. Currently, I'm stuck on the ws-daemon tests, which are all failing because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 😛 , tested and works ✔️
/unhold |
Description
Without which, we cannot remove the gitpod finalizer, pods do not terminate, and as such, we do not scale down nodes
ToDo:
0.30.9
)go test ./...
testsRelated Issue(s)
Fixes CLC-1131
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold