Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subTreeLike and everySubTreeLike methods #30

Merged
merged 2 commits into from
Oct 26, 2015

Conversation

hartzis
Copy link
Contributor

@hartzis hartzis commented Oct 23, 2015

Added subTreeLike and everySubTreeLike methods and tests. #9 (comment)

Solves #22.

@donabrams
Copy link

Why is 'isLike' a string instead of a boolean?

@glenjamin
Copy link
Owner

isLike is a string because I hate seeing mysterious booleans at the call site.

funcCall(true)
// vs
funcCall('isLike')

Bit busy this weekend so proper review might be Monday, looks good at first glance though 👍

@hartzis
Copy link
Contributor Author

hartzis commented Oct 25, 2015

I did the isLike because i saw the use of 'one' here https://github.com/glenjamin/skin-deep/blob/master/skin-deep.js#L211

I could also see using an options object instead:
createFinder(query, predicate, {'isLike': true});

But then you'd probably need to default options to an empty object.

glenjamin added a commit that referenced this pull request Oct 26, 2015
subTreeLike and everySubTreeLike methods
@glenjamin glenjamin merged commit 37d1d2a into glenjamin:master Oct 26, 2015
@glenjamin
Copy link
Owner

Released as v0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants