resolving SQLi in copy-n-paste application #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution refers to which of the apps?
A3 - Copy n Paste
What did you do to mitigate the vulnerability?
I replaced the string concatenation approach used to build SQL queries with prepared statements that utilize placeholders (
?
). By doing this, the user-provided data is handled as parameters by the database driver, preventing any malicious injection from altering the structure of the SQL query.The code in db.go was modified.
Sqlmap results after the change:
More specifically:
SELECT id, username, password FROM Users WHERE username = ?
and passesuser
as a parameter.?
instead of string concatenation with+
.bcrypt
) to further secure user credentials.Did you test your changes? What commands did you run?
Manual Testing:
-1' UNION select 1,2,sleep(5) -- '
) in theuser
field on both/login
and/register
endpoints. The app responded with a "user not found or wrong password" message, not granting unauthorized access or displaying DB errors.sqlmap Testing:
postRequest.txt
with the JSON request for/login
.sqlmap -r postRequest.txt
to see if the parameteruser
orpass
was still injectable.