Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for BookMyName #2316

Merged
merged 4 commits into from
Feb 23, 2025
Merged

Add DNS provider for BookMyName #2316

merged 4 commits into from
Feb 23, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 30, 2024

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
    make build
    rm -rf .lego
    
    BOOKMYNAME_USERNAME=xxx \
    BOOKMYNAME_PASSWORD="yyy" \
    ./dist/lego -m [email protected] --dns bookmyname -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @euskadi31, can you run the command (with your domain, email, credentials, etc.)?

How to test this PR?
  1. You need Go
  2. Checkout the PR:
    git clone https://github.com/ldez/lego.git
    cd lego
    git checkout feat/bookmyname
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your own information (email, domain, credentials):
    BOOKMYNAME_USERNAME=xxx \
    BOOKMYNAME_PASSWORD="yyy" \
    ./dist/lego -m [email protected] --dns bookmyname -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment:
    rm -rf .lego

Closes #1013

@ldez ldez force-pushed the feat/bookmyname branch 3 times, most recently from 0700ac8 to aaede5b Compare November 21, 2024 01:12
@ldez ldez force-pushed the feat/bookmyname branch from aaede5b to 05dfacc Compare January 3, 2025 22:32
@euskadi31

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@euskadi31

This comment was marked as outdated.

@ldez

This comment was marked as outdated.

@euskadi31

This comment was marked as outdated.

@Neustradamus

This comment was marked as off-topic.

@ldez
Copy link
Member Author

ldez commented Feb 23, 2025

@euskadi31 can you try again?

@euskadi31
Copy link

@ldez it's good !

2025/02/23 20:22:29 [INFO] [*.acme.tld] acme: Waiting for DNS record propagation.
2025/02/23 20:22:31 [INFO] [*.acme.tld] acme: Waiting for DNS record propagation.
2025/02/23 20:22:34 [INFO] [*.acme.tld] acme: Waiting for DNS record propagation.
2025/02/23 20:22:40 [INFO] [*.acme.tld] The server validated our request
2025/02/23 20:22:40 [INFO] [acme.tld] acme: Trying to solve DNS-01
2025/02/23 20:22:40 [INFO] [acme.tld] acme: Checking DNS record propagation. [nameservers=8.8.8.8:53,8.8.4.4:53]
2025/02/23 20:22:42 [INFO] Wait for propagation [timeout: 26m40s, interval: 2s]
2025/02/23 20:22:47 [INFO] [acme.tld] The server validated our request
2025/02/23 20:22:47 [INFO] [*.acme.tld] acme: Cleaning DNS-01 challenge
2025/02/23 20:22:47 [INFO] [acme.tld] acme: Cleaning DNS-01 challenge
2025/02/23 20:22:47 [INFO] [*.acme.tld, acme.tld] acme: Validations succeeded; requesting certificates
2025/02/23 20:22:47 [INFO] Wait for certificate [timeout: 30s, interval: 500ms]
2025/02/23 20:22:48 [INFO] [*.acme.tld] Server responded with a certificate.

@ldez
Copy link
Member Author

ldez commented Feb 23, 2025

@euskadi31 thank you 🎉

@ldez ldez removed the state/need-user-tests Need users to test functionality label Feb 23, 2025
@ldez ldez marked this pull request as ready for review February 23, 2025 20:15
@ldez ldez requested a review from dmke February 23, 2025 20:16
@euskadi31
Copy link

@ldez My pleasure !

@Neustradamus

This comment was marked as off-topic.

@ldez ldez added this to the unreleased milestone Feb 23, 2025
@ldez ldez merged commit d8c11a8 into go-acme:master Feb 23, 2025
7 checks passed
@ldez ldez deleted the feat/bookmyname branch February 23, 2025 20:48
@Neustradamus

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add DNS Support for BookMyName
4 participants