Replace deprecated ioutil calls with io package #953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofranssen
force-pushed
the
replace-deprecated-ioutil
branch
from
c927f20
to
3062492
Compare
marcofranssen
force-pushed
the
replace-deprecated-ioutil
branch
from
3062492
to
9dc837e
Compare
VojtechVitek
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Chi is currently compatible with Go 1.14+. See https://github.com/go-chi/chi/blob/master/go.mod#L3
This PR would effectively drop support for older Go versions. Imho, it's not worth the changes.
@marcofranssen Are there any downsides of using old APIs / supporting older versions of Go?
|
Hi, feel free to submit an issue if you're proposing to drop support for older Go versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.