Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strings.Cut in a few places #971

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

JRaspass
Copy link
Contributor

@JRaspass JRaspass commented Feb 4, 2025

Now that we're 1.20+ instead of 1.14+ we can use 1.18's strings.Cut in a few places to simplify code.

Now that we're 1.20+ instead of 1.14+ we can use 1.18's strings.Cut in a
few places to simplify code.
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

Copy link

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechVitek VojtechVitek merged commit 877e876 into go-chi:master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants