Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doctor check to disable the "Actions" unit for mirrors #32424

Merged

Conversation

Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Nov 5, 2024

Resolve #32232

Users can disable the "Actions" unit for all mirror repos by running

gitea doctor check --run  disable-mirror-actions-unit --fix

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Nov 5, 2024
@lunny
Copy link
Member

lunny commented Nov 5, 2024

How about to make this as a doctor sub command?

@Zettat123
Copy link
Contributor Author

Zettat123 commented Nov 6, 2024

How about to make this as a doctor sub command?

It is already a subcommand. gitea doctor disable-mirror-actions-unit

@Zettat123 Zettat123 marked this pull request as draft November 6, 2024 03:59
@github-actions github-actions bot removed the modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin label Nov 6, 2024
@Zettat123 Zettat123 marked this pull request as ready for review November 6, 2024 06:22
@Zettat123 Zettat123 requested a review from lunny November 6, 2024 06:23
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 6, 2024
@Zettat123 Zettat123 changed the title Add a doctor command to disable the "Actions" unit for mirrors Add a doctor check to disable the "Actions" unit for mirrors Nov 6, 2024
@silverwind
Copy link
Member

Why do we make it a doctor instead of a migration?

@Zettat123
Copy link
Contributor Author

Why do we make it a doctor instead of a migration?

Some users may need to enable "Actions" for mirrors. So I made it a doctor command to allow the user to decide if the "Actions" unit of mirrors should be disabled.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 10, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) November 10, 2024 23:08
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 10, 2024
@techknowlogick techknowlogick merged commit a910abb into go-gitea:main Nov 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 10, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 11, 2024
* giteaofficial/main:
  Calculate `PublicOnly` for org membership only once (go-gitea#32234)
  Add `DEFAULT_MIRROR_REPO_UNITS` and `DEFAULT_TEMPLATE_REPO_UNITS` options (go-gitea#32416)
  Add a doctor check to disable the "Actions" unit for mirrors (go-gitea#32424)
  Refactor sidebar assignee&milestone&project selectors (go-gitea#32465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange action errors in mirrored projects?!
5 participants