LoadOptions was ignored with ini.Empty() #361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apenney
force-pushed
the
apenney/fix-backtick-on-write
branch
from
02307d5
to
4e5c433
Compare
This ensures we initialize all the relevant parsing settings when using Empty(). Previously behavior differed between LoadSources and Empty()
apenney
force-pushed
the
apenney/fix-backtick-on-write
branch
from
4e5c433
to
0cd2eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
The Empty() function wasn't ensuring proper initialization of options by skipping the parsing phase that normally occurs with LoadSources. This caused different behavior between files created with Empty() versus those created with LoadSources.
Link to the issue: #360
Checklist