Combine nocase and strictcase tag options under a case option
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
requested review from
mvdan,
johanbrandhorst and
neild
and removed request for
mvdan
|
\cc @prattmic, thank you for the suggestion. |
dsnet
commented
Feb 4, 2025
| out.casing |= nocase | ||
| case "strictcase": | ||
| out.casing |= strictcase | ||
| case "case": |
There was a problem hiding this comment.
We can refactor this in the future to share more code with the format:value logic below, but good enough for now.
WARNING: This commit contains breaking changes. Instead of specifying `nocase` or `strictcase` tag options, use a single `case` tag option, which is a key-value pair where the value can only be 'ignore' or 'strict'. This reads more naturally as `case:ignore` or `case:strict` and is more clear that `case:ignore` and `case:strict` are mutually exclusive tag options.
johanbrandhorst
approved these changes
Feb 6, 2025
mvdan
approved these changes
Feb 6, 2025
neild
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This commit contains breaking changes.
Instead of specifying
nocaseorstrictcasetag options, use a singlecasetag option, which is a key-value pair where the value can only be 'ignore' or 'strict'.This reads more naturally as
case:ignoreorcase:strictand is more clear thatcase:ignoreandcase:strictare mutually exclusive tag options.