Remove base60 support for time.Duration #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By popular demand (or rather lack thereof), remove support for the base60 representation of a time duration. There is no standard for this format and even the name is an attempt at naming something without clear industry basis for what this is called. Updates golang/go#71631
johanbrandhorst
approved these changes
Feb 22, 2025
| @@ -214,8 +213,6 @@ func (a *durationArshaler) initFormat(format string) (ok bool) { | |||
| a.base = 1e3 | |||
| case "nano": | |||
| a.base = 1e0 | |||
| case "base60": // see https://en.wikipedia.org/wiki/Sexagesimal#Modern_usage | |||
There was a problem hiding this comment.
What a lost opportunity to call this format:sexagesimal 😂
There was a problem hiding this comment.
yea... imagine all the bad jokes we would have to deal with if it were called that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By popular demand (or rather lack thereof), remove support for the base60 representation of a time duration.
There is no standard for this format and even the name is an attempt at naming something without clear industry basis for what this is called.
Updates golang/go#71631