fix: unit test Recycle watch resolver tick goroutine #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
harbourlga
force-pushed
the
fix-consul-unittest
branch
from
6688170
to
0d9f2e8
Compare
dosubot
bot
added
size:M
harbourlga
force-pushed
the
fix-consul-unittest
branch
from
0d9f2e8
to
8c6b6fe
Compare
harbourlga
force-pushed
the
fix-consul-unittest
branch
from
8c6b6fe
to
7af5558
Compare
*fix: TestRegistry_Watch Keep the original *chore: update ci consul ver to 1.13.9 *chore: update ci consul ver to 1.20.0 *chore: update ci consul ver to hashicorp/consul:1.20
harbourlga
force-pushed
the
fix-consul-unittest
branch
from
7af5558
to
012b153
Compare
shenqidebaozi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
Which issue(s) this PR fixes (resolves / be part of):
The previous unit test did not recycle the watchresolved tick go routine. It is used to get the latest service information regularly. When running multiple unit tests, the v1/health/service/ interface of consul will be called concurrently, resulting in the X-Consul-Index returned by the server is not the expected result.
Other special notes for the reviewers: