Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ordered map race #1701

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

fix ordered map race #1701

wants to merge 25 commits into from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 28, 2024 •
edited
Loading

fix #1605

suppress #1608

add lock to all ordered map

@trim21 trim21 marked this pull request as draft June 28, 2024 12:58
@trim21 trim21 marked this pull request as ready for review June 28, 2024 13:22
@trim21 trim21 changed the title WIP: try fix map race try fix map race Jun 28, 2024
@trim21 trim21 changed the title try fix map race fix ordered map race Jun 28, 2024
trim21
trim21 commented Jun 29, 2024
View reviewed changes
internal/omap/orderedmap.go Outdated Show resolved Hide resolved
@trim21

This comment was marked as off-topic.

Sign in to view
@trim21 trim21 marked this pull request as draft June 29, 2024 09:21
@trim21 trim21 marked this pull request as ready for review June 29, 2024 09:37
@vergenzt vergenzt mentioned this pull request Jul 16, 2024
Open
@trim21
Copy link
Contributor Author

trim21 commented Sep 7, 2024

any review please?

@pd93 pd93 mentioned this pull request Sep 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map writes
2 participants
@trim21 @pd93