Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: special variables are defined with dotenv at task level #1810

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

vmaerten
Copy link
Member

fixes #1232

What caused the bug? In dotenv, we use the templater (to allow the use of variables in dotenv's path), and if the user includes a special variable in their template, there was a template error because special variables were not defined.

Special variables that are not linked to a task and/or a call are always available.

@vmaerten vmaerten self-assigned this Sep 15, 2024
@vmaerten vmaerten marked this pull request as ready for review September 15, 2024 14:37
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@vmaerten vmaerten merged commit e078261 into main Oct 9, 2024
14 checks passed
@vmaerten vmaerten deleted the 1232/fix-special-vars-with-dot-env branch October 9, 2024 07:14
vmaerten added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Enable dotenv will make go template pipeline be invalid.
2 participants