Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function makes an assumption that there exists 1 font atlas texture, so that
ImDrawList._Data->TexIdCommon
==ImDrawList._CmdHeader.TextureId
. Since we support multiple font atlas textures, that assumption is no longer true andImDrawList::AddConvexPolyFilled
will create a new draw command as needed, givingImGui::ShadeVertsLinearUV
a clean draw command to work with.This workaround forcefully sets the font atlas texture to be the texture the user is trying to draw for the duration of drawing polygons and shading those vertices again, so that no draw command change happens. Once the operation is done, font atlas texture is reverted back to what it was.
This fix is done without thread safety concerns, but an
ImDrawList
should not be touched from multiple threads at a single time, so this is fine.