Fix look_at_from_position() usage in Your first 3D game tutorial
#10666
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
area:getting started
The mob's orientation was previously shifted according to the player's height, which could lead to collision and movement issues that were difficult to diagnose.
Calinou
force-pushed
the
getting-started-fix-look-at-from-position
branch
from
76af79f to
14823a2
Compare
aaronfranke
approved these changes
Feb 10, 2025
tetrapod00
changed the title
look_at_from_position() usage in Your first 2D game tutoriallook_at_from_position() usage in Your first 3D game tutorial
tetrapod00
requested changes
Feb 10, 2025
| // | ||
| // Ignore the player's height, so that the mob's orientation is not slightly | ||
| // shifted if the mob spawns while the player is jumping. | ||
| Vector3 target = new Vector3(player_position.x, start_position.y, player_position.z); |
There was a problem hiding this comment.
Suggested change
| Vector3 target = new Vector3(player_position.x, start_position.y, player_position.z); | |
| Vector3 target = new Vector3(playerPosition.X, startPosition.Y, playerPosition.Z); |
Only tested to compile the single script, didn't test the whole tutorial.
| // | ||
| // Ignore the player's height, so that the mob's orientation is not slightly | ||
| // shifted if the mob spawns while the player is jumping. | ||
| Vector3 target = new Vector3(player_position.x, start_position.y, player_position.z); |
There was a problem hiding this comment.
Suggested change
| Vector3 target = new Vector3(player_position.x, start_position.y, player_position.z); | |
| Vector3 target = new Vector3(playerPosition.X, startPosition.Y, playerPosition.Z); |
skyace65
added
waiting on PR merge
|
This would supersede #8718 |
|
PR #8718 is simpler and would accomplish the same thing, but I'm not sure if we want to encourage the practice of modifying function parameters. |
|
Found another one this would supersede #7123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
look_at_from_position()usage in Squash the Creeps (3D) godot-demo-projects#1165.The mob's orientation was previously shifted according to the player's height, which could lead to collision and movement issues that were difficult to diagnose.