Documentation for shader built-in include files (godotengine/godot#94193) #10703
+59
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial. If someone has a better example in mind I'm open to suggestions. I just wanted something short that isn't too much extra code around the include.
skyace65
added
area:manual
skyace65
requested review from
BastiaanOlij and
tetrapod00
and removed request for
BastiaanOlij and
tetrapod00
fire
reviewed
Feb 23, 2025
| ----------------- | ||
| .. warning:: | ||
|
|
||
| The feature is still been baked! |
There was a problem hiding this comment.
Suggested change
| The feature is still been baked! | |
| The feature is experimental. |
The feature is still been baked!
I'm not sure how this is noted elsewhere, but it seems better to use the wording experimental rather than the concept of feature baking. It's unclear how a software feature is related to cooking.
There was a problem hiding this comment.
Do think that warning is excessive?
Considering what DastiaanOlij said in his PR I'm a bit torn about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents merged feature godotengine/godot#94193 to the end of the compute shader tutorial.
If someone has a better example in mind I'm open to suggestions. I just wanted something short that does not have too much extra code around the include.