-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ v3: (refactor): modify storage interface and add context.Context #2300
base: v2
Are you sure you want to change the base?
Conversation
7488c13
to
f74a69e
Compare
f74a69e
to
c99a521
Compare
I'm OK with this change but it's breaking-change for v2. We should do it for v3. Can you change target to v3-beta @li-jin-gou |
thanks |
@gofiber/maintainers what do we do with this solution, do we want to pursue it further? for this we would have to adapt the storage interface |
We can add new methods like |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Explain the details for making this change. What existing problem does the pull request solve?
Sometimes we need to pass ctx for use tracer and timeout control, so I add a ctx args to interface.
Type of change
Please delete options that are not relevant.
Checklist:
Commit formatting:
Use emojis on commit messages so it provides an easy way of identifying the purpose or intention of a commit. Check out the emoji cheatsheet here: https://gitmoji.carloscuesta.me/